Handle multiple paragraphs of content #249
Closed
+5,676
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
internal/parsers/markdown.go:102
- [nitpick] The variable name
currentParagraphsis ambiguous. It should be renamed toaccumulatedParagraphs.
var currentParagraphs string
internal/parsers/markdown.go:167
- Ensure that
accumulatedParagraphsis reset correctly only when necessary to avoid losing accumulated text.
currentParagraphs = ""
…instructions. a little refactoring of prereq examples.
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
…nment variables before executing the code block
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
… a real enquiry yet.
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
Need to export Env Vars
rgardler-msft
temporarily deployed
to
ScenarioTesting
GitHub Actions
Inactive
|
@rgardler-msft Is this PR ready for review yet or are you still making changes to it? |
…ationEngine into upstream_issue_32
|
I forgot I had opened a PR for this and then got carried away doing unrelated work in the branch. I am going to close this as it I need to cherry pick to make it a reviewable PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle multiple paragraphs of content in
ie interactive. Fixes #32